#63 : Provide a configuration API

xwikisas / application-ldapuserimport

GNU Lesser General Public License v3.0

0 stars 3 forks source link

#63 : Provide a configuration API #65

Closed aubincleme closed 1 year ago

aubincleme commented 1 year ago

Introduce the LDAPUserImportConfiguration role
Provide a default implementation of the LDAPUserImportConfiguration based on the configuration object located in xwiki:LDAPUserImport.WebHome
Refactor the default LDAPUserImportManager to use this configuration API
Refactor the LDAPUserImportUIX to use this API
Update the wrapping of the XWikiLDAPConfig to use the LDAPUserImportConfiguration

aubincleme commented 1 year ago

@mflorea ready for another review, with most of the issues corrected. The only decision to take is to acknowledge that we can't use the internal APIs of xwiki-platform-configuration for now.

mflorea commented 1 year ago

I would still use AbstractDocumentConfigurationSource even if it's internal (it simplifies a lot your code), until we have https://jira.xwiki.org/browse/XWIKI-20318 . But if you don't want to, that's fine with me. The PR looks good otherwise.

aubincleme commented 1 year ago

Thanks for your feedback @mflorea ! For now, I'd prefer going without the use of an internal core API ; just for the sake of making sure that this app will be able to work on future XWiki version without us having to quickly fix it if we ever do a change at the AbstractDocumentConfigurationSource