search

xwikisas / application-licensing

Manage and enforce application licenses for pro extensions
GNU Lesser General Public License v2.1
1 stars 8 forks source link

Notification about automatic upgrades does not show message about the update done or failed #154

Open petrenkonikita112263 opened 10 months ago

petrenkonikita112263 commented 10 months ago

Prerequisites:

Step to reproduce:

  1. Enable auto-upgrade for an installed pro app from the License page. Administer XWiki → Extensions → Licenses. After enabling it should be green color.
  2. Click on Notifications bell → Settings in Applications section enable Automatic upgrades (or use direct link http://localhost:8080/xwiki/bin/view/XWiki/Admin?category=notifications)
  3. Go to Job Scheduler page via shortcut or direct link http://localhost:8080/xwiki/bin/view/Scheduler/
  4. Trigger both jobs "Licensed extension upgrade" and "New version available" (here, I'm not sure is it enough to trigger only "New version available" or not)
  5. Wait a bit and check 2nd page tab, which you had opened before, refresh it, see a new version number for pro app

Actual result: Observing a new version number in the license table, the notification won't have information regarding the successful upgrade.

Expected result: Admin user sees information about recent upgrades in notifications.

petrenkonikita112263 commented 10 months ago

Note that I've also tried, to rollback version of Pro Macros downgrade to v1.11.0 and re-triggered job, but this time I have an enabled notifications. I assume the sequence that must be done first: enable auto upgrade or notification doesn't matter, even on 2nd auto upgrade I still don't receive notification

oanalavinia commented 10 months ago

Please check https://github.com/xwikisas/application-licensing/issues/88#issuecomment-777341542 . As is said in here, the System filter should also be disabled to be able to receive a notification, since this is send by the superadmin

petrenkonikita112263 commented 10 months ago

The issue is still reproducable, even with disabled notification for Admin user, re-downgrading with further re-triggering job updater → doesn't display notification about the finished upgrade of pro apps. Same is true for normal (non-admin) user who has the disabled type of notification by default.