search

xwikisas / application-meeting

Application to handle meetings
0 stars 7 forks source link

The duration in meeting doesn't automatically change #33

Closed CostiChD closed 5 years ago

CostiChD commented 6 years ago

Issue: https://jira.xwiki.org/browse/XAMEETINGS-142

Steps to reproduce:

1 .Click on Meetings from Applications Panel

  1. Add a new meeting with a specified Duration e.g. 1h 30 min
  2. Click on Meeting again
  3. Click on Calendar
  4. Resize the meeting duration e.g. drag the box to have a 3h Duration
  5. Click on Meetings
  6. Expected results: The Duration is automatically changed in the LiveTable for that meeting.

Actual results: The Duration remains at "1h 30 min".

NOTE: The solution is to Edit the meeting, refresh the page (ctrl + f5) then press Save & View. This won't change the Duration in view mode so you have to refresh the page again for that to be changed.

CostiChD commented 6 years ago

NOTE 2: After resizing the meeting duration( drag in calendar overview), if you just go to that meeting page(here the value will still be the old one until you refresh the page) the duration will be updated in the livetable.

lucaa commented 6 years ago

Please note that all duration-related issues should be looked at together with https://jira.xwiki.org/projects/XAMEETINGS/issues/XAMEETINGS-130 - I think before we invest time in fixing the issues related to the current duration implementation we should consider migrating to a proper duration management.

CostiChD commented 6 years ago

An approach would be just to keep the duration property and use the custom display to show it in the livetable(from the WebHome), like it was before with the durationString property. Also (using custom display) we would need to get the duration(using 2 inputs: one for the hours and one for the minutes) when editing the meeting. I dont see the point of using an endDate property because usually meetings have a shorter duration than 24 hours and this could be done just with the duration property. Another thing that we should consider is that the "duration" property actually has the type Static List, even tho it keeps a number.(this is the reason why the Duration sorting does not work right now in the livetable) This way we can get rid of durationHour, durationMinutes, durationString, calc and hasBeenEdited properties and keep just the "duration" property.