search

xwikisas / application-meeting

Application to handle meetings
0 stars 7 forks source link

Clear the default start date #9

Closed acotiuga closed 6 years ago

acotiuga commented 6 years ago

All meetings have the start date set to 07/07/2016 15:45: https://jira.xwiki.org/browse/XAMEETINGS-149.

lucaa commented 6 years ago

you wrote in the commit comment: "It looks like the 'Empty Is Today' is not working as expected." and you also deactivated the "empty is today" for the meeting start date.

well, it does work as expected: if you're trying to save a document with an empty start date, it fills in the date of today. This applies to the template as well, and the values from the template are used when creating a new document. The issue is caused by careless saving and commit of the template document, not by the functioning of the "empty is today" option, imo. Otherwise put, the start date of the meeting can be "empty is today" - and probably should - , we just need to be extra careful about the meeting template we pack in the application.

acotiuga commented 6 years ago

OK, I see the point, let me fix this. Thanks!

lucaa commented 6 years ago

note that being able to create meetings with an empty date without that date being filled in upon save (empty is today on false) is probably something that can be interesting as a feature as well, it's not necessarily "wrong". My intention in the initial remark was to highlight that it's a different decision than the current issue, the current issue is only about the date that is saved in the template.

acotiuga commented 6 years ago

Wrong as not needed in the previous commit.