search

xwikisas / application-xpoll

Simple poll application, Doodle like
0 stars 6 forks source link

Bug when displaying the user name in the poll table #32

Closed vmassol closed 5 years ago

vmassol commented 5 years ago
team_activity___cooking_workshop__xpoll_team_activity____cooking_workshop_webhome__-_xwiki
vmassol commented 5 years ago

The problem is that wiki=true is used in {{html clean='false' wiki='true'}} and the URL inside the HREF is parsed as wiki content... (since getUserName() returns HTML).

vmassol commented 5 years ago

Idea: use a better displayer for the user. We have displayers showing both avatars and name.

lucaa commented 5 years ago

Quick solution: getUserName() takes a second parameter controlling whether html should be generated or not - so replacing all getUserName(user) with getUserName(user, false) does the job Long solution: proper sheet that avoids using {{html wiki=true }} (which is generally a bad idea and the proof of that is this issue). This solution could, as Vincent said, also include an improvement of the user display.

lucaa commented 5 years ago

On a 1.10.4 version of the poll application, on a subwiki of a farm with global users , this issue is not fixed as it's replaced with a new issue: broken avatar macro and broken link to the user page: image

I am reopening this issue also it's arguable whether the bug is a new one or the same as this one (it's obviously not the same, but the user display is still not ok).