search

xwikisas / application-xpoll

Simple poll application, Doodle like
0 stars 6 forks source link

Proposal votes are not being recorded on JAVA 17 #82

Closed ilieandriuta closed 3 years ago

ilieandriuta commented 3 years ago

Environment: Windows 10 Pro 64bit, Firefox 93, using an instance of XWiki 12.10.10 on Tomcat 9.0.54/ Oracle 19c (tested also on XWiki 13.8 Jetty/HSQLDB) with Polls Application (Pro) 2.0.4, Java 17 build 17+35-LTS-2724 from Oracle

STEPS TO REPRODUCE

  1. Start XWiki with JAVA 17
  2. Go to Polls Pro application home
  3. Create a new poll with several proposals, with status 'Active' and Type 'Allow multiple options' (or 'Can select a single option')
  4. Click 'Save & View'
  5. Under a proposal, click the checkbox (or radio button)
  6. Click 'Save'

EXPECTED RESULTS

The vote for respective proposal is saved, the bottom counter for respective proposal column changes, as well as 'Number of votes' counter.

ACTUAL RESULTS

Although the green message 'Saved' is displayed on the bottom of the page, the vote doesn't seem to be recorded. None of the counters change (even after page refresh) and moreover, on the Polls home LiveTable there is no Winner displayed for the respective poll.

The issue doesn't reproduce with JAVA 11.

Vote not recorded after save: Polls_Proposal_not_saved1

No winner displayed: Polls_No_Winner1

mflorea commented 3 years ago

@ilieandriuta where does the "anymore" come from? Did it worked before on Java 17? I don't think so, so it should be just "Proposal votes are not being recorded on JAVA 17".

@trrenty could you check if the issue still reproduces with your latest changes? Thanks.

ilieandriuta commented 3 years ago

@ilieandriuta where does the "anymore" come from? Did it worked before on Java 17? I don't think so, so it should be just "Proposal votes are not being recorded on JAVA 17".

Sorry, I was thinking that they are not being recorded as they used to be on earlier Java versions, but it makes sense to remove it. Thanks!

trrenty commented 3 years ago

@mflorea @ilieandriuta It seems that after my changes, the error doesn't reproduce anymore. I tested it on Kubuntu 21.04, Chrome 91, XWiki 13.8 Jetty/HSQLDB, Java 17 build 17+35-LTS-2724.