Condorcet method poll UI issues

[ane-gabriela]

This issue is related to the new functionality Condorcet method poll

Steps to reproduce:

1. Create a new poll with 8/9 proposals, Status "Active" and Type "Allow multiple options in order"

Expected results: A new poll is created with a simple/easy to use UI for the user, keeping the same flow as the other Type options (single and multiple option).

Actual results:

1. The profile picture is overlapping the user name
2. The Recent Polls panel is overlapping some of the selected options
3. Scores are present without any selection -> As per the multiple option selection Scores are 0 until the user makes a selection
4. The "Select a value" drop-down list isn't that readable with the color selection
5. In the Polls Home page all options appear as Winner -> As per the multiple option selection the Winner appears only after a selection is made

Note: Also noticed that French translation is missing for "Select a value"

Environments: Windows 10, XWiki 13.4.5 with MYSQL 8.0 and IE 11, XPoll Application (Pro) API 2.1

[trrenty]

Addressed point one, two and six of the isue.

With regards to the second point:

The Recent Polls panel is overlapping some of the selected options

This is an issue that also affects the other type of polls, namely single option and multiple option. The commit fixes the problem by enabling scrolling if the table overflows and allowing more proposals to fit in before overflowing.

For a window size of 1920p, 9-10 proposals fit properly given any poll type.

Another solution I implemented was to duplicate the table and evenly disperse the proposals beween each of them. This way, the scrolling wasn't needed but having a poll with many votes and many proposals would create a very long page.

A proper solution that would also accomodate mobile devices would require, in my opinion, a complete overhaul of the UI. Displaying the poll with the help of a bar/pie chart would be friendly for both desktops and mobile devices.

Is the current solution good? Is the proposed solution worth investing in? WDYT?

With regards to the third point:

Scores are present without any selection -> As per the multiple option selection Scores are 0 until the user makes a selection

This concerns the way the condorcet winner is calculated. If there are no votes, all the proposals have equal, max scores whereas the multiple option poll is calculated by counting the votes each proposal has got.

With regards to the fourth point:

The "Select a value" drop-down list isn't that readable with the color selection

"Select a value" option is disabled - you can only select a proposal from the dropdown. This being said, I don't think there is a problem with it not readable. WDYT?

With regards to the fifth point:

In the Polls Home page all options appear as Winner -> As per the multiple option selection the Winner appears only after a selection is made

This also concerns the way the condorcet winner is calculated. As I said previously, when there are no votes, all proposals have the maximum possible score -> everybody is a winner, thus, the home page will display all the proposals as winners. Having this in mind, should this be handled? WDYT?

[mflorea]

From what I can see the remaining points are not real problems. The only question is whether we want to work on improving the voting UI for Condorcet polls. For this we would have to do a bit of refactoring so that each poll type can provide a custom display for both edit (vote) and view, in a generic way.

[mflorea]

Best is probably to close this issue for 2.1.2 since it already has commits and open another issue for adding support for different display per poll type.

[mflorea]

I reported #90 .