xwikisas / macro-pdfviewer

0 stars 4 forks source link

Add a copyable link of the PDF file location in the macro toolbar #40 #41

Closed trrenty closed 2 years ago

trrenty commented 2 years ago

image

In the previous example, the clipboard was populated with: http://localhost:8080/xwiki/bin/download/PdfTest/WebHome/helloworld.pdf?rev=1.1

image

This issue had me modify many files:

Note: I used URLSearchParams, a feature that is not supported on IE, because pdf.js is already using it. They dropped support for non-chromium IE since 2.6.347. Since the commit on PDF Macro that pulled pdf.js through a webjar, we are using 2.9.359.

mflorea commented 2 years ago

Note: I used URLSearchParams, a feature that is not supported on IE, because pdf.js is already using it. They dropped support for non-chromium IE since 2.6.347. Since the commit on PDF Macro that pulled pdf.js through a webjar, we are using 2.9.359.

They mention that we can use the -es5-dist.zip package if we need to support IE11, so we should try that (if it's not too complex). The fact is that IE11 support has been dropped only in XWiki 14.0 and we still need to support XWiki 11.10+ so we still need to support IE11. If we want to make an exception for the PDF Viewer macro we need to ask the support (and client teams) about this. It's not our decision.