The file parameter cannot be edited correctly when comprising multiple entries

xwikisas / macro-pdfviewer

0 stars 4 forks source link

The file parameter cannot be edited correctly when comprising multiple entries #43

Closed slauriere closed 1 year ago

slauriere commented 2 years ago

Steps to reproduce

Insert pdfviewer macro in a page and edit macro parameters
From the macro form, upload and select two files: "file1.pdf" and "file2.pdf"
Hit "Submit"
Edit again macro parameters

Actual result

The "file" form input in the macro dialog displays "file1.pdf,file2.pdf" as a single item in the list.
Beside being unexpected visually, it has two functional consequences that are unwanted:
- "file1.pdf" and "file2.pdf" are present in the list of suggestions while they should not since they have been selected already.
- Removing one of the two entries requires emptying the "file" field and reslecting the file to be kept, instead of just removing the target file.

pdfviewer-multiple-entries-edition

Expected result

The "file" form input should display the two entries as individual entries "file1.pdf" and "file2.pdf".

Environment

XWiki 14.6
PDFViewer macro 2.4

oanalavinia commented 2 years ago

Duplicate of #37, which was closed as Won't fix since this is CKEditor bug. See https://github.com/xwikisas/macro-pdfviewer/issues/37#issuecomment-1083195879

slauriere commented 2 years ago

Hello @oanalavinia, Thanks. I understand it's close to #37 however it's present in XWIki 14.6 which is supposed to contain a version of the CKEditor integration which contains the fix, doesn't it? (application-ckeditor got moved to xwiki-platform so I'm not sure about the exact version to check).

slauriere commented 2 years ago

And #37 seems to focus on the commas issue but does not seem to cover the fact that we get a single entry in the selectize input while several entries would be expected, does it?

oanalavinia commented 2 years ago

Indeed, reopening since the issue should be fixed for XWiki version 14.6 since the migration was done starting with 14.6RC1 https://jira.xwiki.org/browse/XWIKI-19928 and CKEDITOR-425 was closed before this.

As for the issue #37, it was suppose to cover also the fact that you get only one entry, but I discovered that it doesn't actually mention it (but just note that the behavior was the same)

trrenty commented 1 year ago

The issue is not a specific to this application but to the CKEditor. The issue was reported on platform as well as on the CKEditor contrib project. https://jira.xwiki.org/browse/XWIKI-20492 and https://jira.xwiki.org/browse/CKEDITOR-500. They were solved as of versions 14.10.3 / 15.0 XWiki platform and 1.64.9 on contrib project.