The trusted domains configuration option does not seem to work properly - Githubissues

xwikisas / macro-pdfviewer

0 stars 4 forks source link

The trusted domains configuration option does not seem to work properly #56

Closed aubincleme closed 4 months ago

aubincleme commented 6 months ago

Steps to reproduce :

Install the PDF viewer application 2.5.3 on XWiki 15.10.x,
Add the following macro in one of the pages :

{{pdfviewer file="https://www.dfn.de/wp-content/uploads/2021/12/satzungdfn.pdf"/}}

Go in the administration, add https://www.dfn.de/ to the list of trusted domains in the PDF Macro configuration (currently this config is not documented − see https://github.com/xwikisas/macro-pdfviewer/issues/55, but are notes about it in https://github.com/xwikisas/macro-pdfviewer/issues/15).
Save, clear your cache, clear your cookies
Go back to the page where you added the PDF viewer macro
Observe that the PDF doesn't load :

trrenty commented 4 months ago

Hello, @aubincleme . The list of trusted domains in the PDF Macro configuration refer to the viewer domains, which, in most cases, means the domain of the xwiki server.

After reviewing this issue and #57 (where you used a bad example taken from the documentation) I also got to realise how lacking the documentation of this app is.

Will close this issue as invalid and update the documentation as per #55