Improve display of view-file macro #239

[ChiuchiuSorin]

239

Created modals and custom box macro to better display the files used with the view-files macro.

• Macro view:

• Full view:

• Table test:

• Thumbnail demo: https://github.com/xwikisas/xwiki-pro-macros/assets/104432589/a1970431-2657-4600-acff-23733bcab5ba

  • The thumbnail option only returns a hyperlink to a modal to view the selected file, without an image preview, as currently there is no support for creating an image from an office or pdf file.

[trrenty]

I also think that it would be more intuitive to have something more stylized than a simple link. I think its not expected to have a link that opens a modal.

Maybe something like this:

Ofc this is subject to discussion. Maybe @snazare could give her opinion as well. And u, @ChiuchiuSorin , ofc :P

[snazare]

Hi :) Indeed @trrenty I agree that it would be good to style the link as suggested. When clicking on an attachment link usually the user expects the file to download. However, considering the fact that:

1. you can download the file from the attachments section
2. users coming from Confluence will expect the same behaviour as in Confluence - to open the file in a modal box when clicking on the thumbnail

I would keep the behaviour of opening the file in a modal when clicking on the styled link.

[ChiuchiuSorin]

Tried two thumbnail styles, I added for both of them a file type specific icon: Style 1, using XWiki button wrapper: Style 2, using bootstrap default: I left only those files that are not supported by office macro or pdf to be displayed as a hyperlink (as you can see in the images) Personally, I'd prefer the first option, as it is more visible and it adapts the aspect depending on the used skin WDYT @snazare and @trrenty ?

[snazare]

Hi @ChiuchiuSorin I agree, let's go with the XWiki button so that it follows the look&feel defined in the instance. Nice touch on the icons :).