Domain permissions

[aleemb]

Might be a better idea to set the URL matches pattern to:

*://*.google.*/*

Running the script on all domains will adversely affect performance and security.

[xwipeoutx]

The rules for matches pattern is fairly restrictive. See http://developer.chrome.com/extensions/match_patterns.html.

In particular, their example of a bad pattern. http://foo.*.bar/baz : If '*' is in the host, it must be the first character

So without an exhaustive list of countries, I can only match everything

[aleemb]

You are right. Google publishes a list of all supported domains you can get from here: http://www.google.com/supported_domains

ref: http://stackoverflow.com/questions/11069644/support-all-google-domains-in-a-content-script

Aleem

On Sat, Oct 5, 2013 at 12:29 PM, xwipeoutx notifications@github.com wrote:

The rules for matches pattern is fairly restrictive. See http://developer.chrome.com/extensions/match_patterns.html.

In particular, their example of a bad pattern. http://foo.*.bar/baz : If '*' is in the host, it must be the first character

So without an exhaustive list of countries, I can only match everything

— Reply to this email directly or view it on GitHubhttps://github.com/xwipeoutx/undirect/issues/1#issuecomment-25743714 .

[aleemb]

There is also include_globs option and an alternative solution using the same:

http://stackoverflow.com/questions/16186956/how-to-load-a-content-script-on-all-google-international-pages

Aleem

On Sat, Oct 5, 2013 at 12:34 PM, Aleem B aleemb@gmail.com wrote:

You are right. Google publishes a list of all supported domains you can get from here: http://www.google.com/supported_domains

ref: http://stackoverflow.com/questions/11069644/support-all-google-domains-in-a-content-script

Aleem

On Sat, Oct 5, 2013 at 12:29 PM, xwipeoutx notifications@github.comwrote:

The rules for matches pattern is fairly restrictive. See http://developer.chrome.com/extensions/match_patterns.html.

In particular, their example of a bad pattern. http://foo.*.bar/baz : If '*' is in the host, it must be the first character

So without an exhaustive list of countries, I can only match everything

— Reply to this email directly or view it on GitHubhttps://github.com/xwipeoutx/undirect/issues/1#issuecomment-25743714 .

[xwipeoutx]

Thanks to @CoolOppo, all done! New package should appear on the chrome webstore when it finished processing