xwjcool123 / BlockTunerMod

Minecraft Note Block User Interface
GNU Lesser General Public License v3.0
28 stars 6 forks source link

Incompatibility with Tweakaroo's Flexible Block Placement #12

Open Hexagonl opened 1 year ago

Hexagonl commented 1 year ago

Replicating

  1. Install the Tweakeroo mod (https://www.curseforge.com/minecraft/mc-mods/tweakeroo)
  2. Go to the mod's config through the Mod Menu or by pressing X + C
  3. Enable "tweakFlexibleBlockPlacement" under the Tweaks tab
    • If you want to double check, make sure flexibleBlockPlacementOffset is set to the Left Control key under the Hotkeys tab
  4. Hold Left Control and right click on a noteblock. The Tweakeroo overlay for the Flexible Block Placement tweak will appear on the face of the noteblock you're looking at. However, it does not open the BlockTuner interface.

In the following demonstration video, you can tell whenever I'm holding Left Control by the note preview next to the crosshair, and it's obvious when I right click lol:

https://github.com/xwjcool123/BlockTunerMod/assets/61996651/7f55e777-e95d-4b97-a07a-25952e733671

Current workarounds

You can temporarily disable the Flexible Block Placement tweak in order to access the BlockTuner interface, although it would be nice to just leave that Tweakeroo tweak enabled.

Possible fixes

idfk lmao, ig the Tweakeroo mod just blocks BlockTuner from seeing the noteblock or something idk

Comments

I really love this mod, it's insanely useful (although I don't use the MIDI keyboard feature, it's still very nice to have!) Version 1.1.0's new addition that requires left control to be held makes this mod much better to work with too. Of course, it would be nice to be able to customize this through the Mod Menu lmao. Keep up the work!

xwjcool123 commented 1 year ago

Noted. someone else also asked me if I can change ctrl to another key. Now I know why and I'll probably release a solution to this soon.

xwjcool123 commented 1 year ago

It seems that Tweakeroo intercepts the interaction before the callback is sent to BlockTuner. A workaround is to set another hotkey for flexible block placement, e.g. Right Alt, or some combinations that are easy to reach but rarely used. I know this is not perfect, and it may take some time to adjust to this, but I want to center functions of my mod around left Ctrl, which is the default modifier key to get pick stack with NBT. Sorry for the inconvenience.

image

xwjcool123 commented 1 year ago

I'll keep this issue open for now. However, if you find the solution good enough, feel free to close it. I'll write it down in README so that people with Tweakaroo can have something to refer to.