xwmario / rutorrent

Automatically exported from code.google.com/p/rutorrent
0 stars 0 forks source link

Wrong version for Clients in Peers tab (regex identify problem) #901

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Click peers for current download

What is the expected output? What do you see instead?
1. Watch Client, e.g. uTorrent 3.4.1 is -UT341-%...
2. Should be uTorrent 3.4.1

What environment are you using?
1. My ruTorrent version is v3.6
2. My rTorrent version is v0.9.0/0.13.0
3. Web server ist Apache v2.2
4. Browser is any

Are some errors present in the web-server log?
no

Are some errors present in the browser error console?
no

Please provide any additional information below.

Change if(str.match(/^-[A-Z~][A-Z~][A-Z0-9][A-Z0-9]..-/i))
to if(str.match(/^-[A-Z~][A-Z~][A-Z0-9][A-Z0-9]{1,3}-/i))
and the issue is gone.

Original issue reported on code.google.com by mathiasmartin82 on 18 Apr 2014 at 7:37

GoogleCodeExporter commented 8 years ago
Real uTorrent 3.4.1 peer-id is -UT0341-.  
-UT341- is a fake.

Original comment by novik65 on 18 Apr 2014 at 8:04

GoogleCodeExporter commented 8 years ago
Are you 100% sure?
http://www.extremtorent.org/clients.php

uTorrent beta version seems a bit more difficult because users wrote this in 
uTorrent forums, too. They changed way of versioning in there beta versions.

Original comment by mathiasmartin82 on 18 Apr 2014 at 8:09

GoogleCodeExporter commented 8 years ago
100% sure i will be in a grave only. uTorrent use Azureus-style for creating 
peer-id. It require 4 digits. See 
https://wiki.theory.org/BitTorrentSpecification#peer_id for details.

>They changed way of versioning

Where they wrote about that?

Original comment by novik65 on 19 Apr 2014 at 7:27