search

xwmx / pandoc-ruby

Ruby wrapper for Pandoc
MIT License
340 stars 43 forks source link

Fix test warnings, consistently wrap pandoc #19

Closed dalehamel closed 8 years ago

dalehamel commented 8 years ago

@alphabetum I fixed a big where strings and binary output weren't consistently getting input files as an array (specifically, you couldn't pass an array of input files to binary output).

I've abstracted the common logic into the 'execute_pandoc' wrapper around execute.

I also noticed a huge number of warnings in the tests, which I fixed. The lockfile was corrupted, so I fixed that too.

Is there travis CI for this project? The project seems to be a little bit abandoned, do you still want to maintain?

xwmx commented 8 years ago

Thanks for the fixes! These changes are included in version 2.0.1.

In order to have more information in the commit messages, I created two new commits for the Gemfile.lock problem ( 5e1f87b ) and the warnings ( 754b0f1 ), both of which appear to be due to gem version issues. This pull request was then merged in to get the execute_pandoc changes and make sure that you got credit for the change.

Travis CI was never fully set up for this project, but I'll look into finishing that. I'm not sure what you mean by the project seeming abandoned. The last version was released about a month ago.

Thanks again for the bringing attention to and fixing these warnings and bugs!