search

xwp / block-scaffolding-wp

WordPress plugin template for extending Gutenberg
https://join.xwp.co
18 stars 17 forks source link

Automerge minor and patch updates #49

Open kasparsd opened 4 years ago

kasparsd commented 4 years ago

Reduce Renovate noise. Should be a fine strategy for a scaffolding repository.

derekherman commented 4 years ago

@kasparsd I'm not 100% convinced that auto merge is a good strategy since the Gutenberg packages have a tendency to break backwards compatibility. Also, this would mean the strategy will be the default for the plugins that are created from it. Thoughts?

kasparsd commented 4 years ago

Also, this would mean the strategy will be the default for the plugins that are created from it.

That's a great point -- I didn't think of it.

I suggest that it should be up to the developers of that new package to change that. In theory, the the CI checks should be able to catch the majority of issues during the CI build process and tests which would cause the minor updates to not be merged just like it happened in #48.

Currently with the manual merges I'm not doing any regression testing with the minor dependency updates anyway so I would suggest the automerge as the default behaviour due to it being better for security and maintainer sanity.

The plugin releases to WP.org and/or git tags would have to be manual anyway so any potential issues would be uncovered during that process.