xwp / block-scaffolding-wp

WordPress plugin template for extending Gutenberg
https://join.xwp.co
18 stars 17 forks source link

Remove Dockerfile and Vagrantfile? #93

Open kienstra opened 3 years ago

kienstra commented 3 years ago

What do you think about removing the Dockerfile and Vagrantfile?

Most recent candidates have had problems with them.

They usually lose 1-2 days debugging them (though probably not working the whole day on them 😄 ).

The files might be fine. Environments are just hard to set up, and sometimes the candidates don't see errors when they fail.

My instructions for the project say the bundled environments are optional, but almost everyone tries to use the Dockerfile or Vagrantfile.

Most candidates probably have their own WP environment.

Sorry to keep opening issues to this repo, just thinking of how to speed up the trial projects.

kienstra commented 3 years ago

The Dockerfile doesn't work on my local, but it's probably my fault.

It's the same error as other Docker environments. It's probably not a problem with this plugin.

docker compose up -d ```sh Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them [+] Running 0/0 â ¿ Network block-scaffolding-wp_default Error 0.0s failed to create network block-scaffolding-wp_default: Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network ```
kienstra commented 3 years ago

Does this sound like a decent idea?

One candidate kept trying and failing to use the bundled environment, even though I asked him in Slack to use his own environment.

If you're up for it, I'll open the PR for this.