search

xwp / material-design-wp-plugin

Material Design plugin for WordPress
13 stars 6 forks source link

Block previews #292

Closed jwold closed 3 years ago

jwold commented 4 years ago

Feature description

Generate block previews of the blocks for the Material Library. Assuming that we generate what the component displays, and then tweak accordingly. This is primarily a dev task with design review.

Note: If I'm wrong on this I'm happy to propose the design first.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

csossi commented 4 years ago

Some of these previews have a lot of empty space - should these be adjusted?: image image

jwold commented 4 years ago

Good point Claudio. With these examples we could add more cards to fill up the space.

jwold commented 4 years ago

I don't see this as a blocker, but a nice to have. I've seen examples of other plugins do something similar, and for now I think this is ok to ship.

jauyong commented 3 years ago

@mattchungxwp to remind jason to create ticket for Claudio's bug: https://github.com/xwp/material-design-wp-plugin/issues/292#issuecomment-659113603