search

xwp / site-performance-tracker

Allows you to detect and track site performance metrics
GNU General Public License v2.0
96 stars 15 forks source link

Fix event error for GA, code clean up #26

Closed piotr-bajer closed 3 years ago

piotr-bajer commented 3 years ago

The current solution sends config and js commands when Google Analytics is used as a provider. These commands are not supported and thus have been removed.

Instead, the measurement version info is sent directly as an event parameter.

The metric_rating dimension was used in gtag event, which was never defined. Now it is removed.

The metric1 metrics declaration has also been removed as it is not being used.

mehigh commented 3 years ago

@piotr-bajer can you look into the travis failure? 159 | ERROR | [x] Tabs must be used to indent lines; spaces are not | | allowed | | (Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed) Then we can get this merged.