search

xwp / site-performance-tracker

Allows you to detect and track site performance metrics
GNU General Public License v2.0
96 stars 15 forks source link

Bug: Interface in the UI #56

Closed mehigh closed 2 years ago

mehigh commented 2 years ago

After the latest version (0.1.1+), the UI of the interface doesn't reflect the hard-coded values, showing the placeholders as if it wasn't already configured Screenshot 2022-03-07 at 14 31 41

manuelRod commented 2 years ago

@mehigh what do you mean with "doesn't reflect the hard-coded values". When I do a fresh install, I get the placeholders. When I set up settings and save, I get the saved settings. Am I missing something?

manuelRod commented 2 years ago

Oh, I see, you mean when using add_theme_support to configure the plugin right? But, how it should work ideally? Do settings screen overwrite add_theme_support or the opposite? From the documentation, I see settings should be set using add_theme_support. Should Settings screen be read-only then?

mehigh commented 2 years ago

Hi,

Historically we've only had add_theme_support for configuring the plug-in. When these are present, we want the setting screen to reflect the configuration in code via readonly fields.

The documentation could receive an update too... since we're now having a setting screen.

We're having many websites with it setup in the code and want things not to be confusing when we're updating the plug-in for them.

manuelRod commented 2 years ago

@mehigh PR ready 57