xwp / stream

🗄️ Stream plugin for WordPress

https://wordpress.org/plugins/stream/

GNU General Public License v2.0

411 stars 116 forks source link

Add Two Factor connector #1386

Closed dd32 closed 3 weeks ago

dd32 commented 1 year ago

Feature Request

The WordPress.org plugin "Two Factor" is used by 50k+ installs, having the actions from that plugin available in Stream would be beneficial to Stream users.

This is an ideal 2FA plugin to add to stream, as it's vendor neutral, not developed by any single company, and will add the appropriate actions/terms for other 2FA plugins to integrate with Stream in a consistent manner.

dd32 commented 3 months ago

Just noting that I've started some work on this as a custom connector on WordPress.org: https://github.com/WordPress/wporg-mu-plugins/blob/trunk/mu-plugins/plugin-tweaks/stream/class-connector-two-factor.php via https://github.com/WordPress/wporg-mu-plugins/pull/643

tharsheblows commented 2 months ago

@dd32 Thank you! I'm using that when adding the connector to Stream. 😊

I'm changing the connector name to "twofactor" so you can pre-emptively remove the Stream connector and use your own more easily.

I'm also removing the actions from the WebAuthn Provider plugin... I think this is the right thing to do at this moment in time but if you disagree, please tell me!

dd32 commented 2 months ago

@tharsheblows That's perfectly fine! WebAuthN will land in the two-factor plugin at some point, unsure if it'll be from that plugin or even follow the same methods/naming.

Thanks for looking into this :)