xwp / stream

🗄️ Stream plugin for WordPress
https://wordpress.org/plugins/stream/
GNU General Public License v2.0
405 stars 119 forks source link

Update audit log message for comments transitioning status #1430

Closed goldenapples closed 10 months ago

goldenapples commented 1 year ago

This adds the post title to the audit log text for comments that are transitioning status, to be consistent with the other messages in the comments connector.

Describe your approach and how it fixes the issue.

Checklist

Release Changelog

Release Checklist

Change [ ] to [x] to mark the items as done.

kasparsd commented 10 months ago

@goldenapples Looks like the missing CI runs for this pull request did actually introduce a regression for the unit tests:

https://github.com/xwp/stream/actions/runs/6178185169/job/16770933181?pr=1448#step:9:60

Would you be able to create a follow-up pull request to fix that test?

https://github.com/xwp/stream/blob/4979211dcd278d09259e838167982c883ee7af24/tests/tests/connectors/test-class-connector-comments.php#L420-L422

goldenapples commented 10 months ago

Just opened a PR to fix the unit test, #1450. I didn't run tests locally, and they're not set to run on forks, but I updated the assertion to match the expected output.