xwp / stream

🗄️ Stream plugin for WordPress
https://wordpress.org/plugins/stream/
GNU General Public License v2.0
407 stars 116 forks source link

Check if entry/lead ID is empty in "gform_post_note_added" action #1447

Closed zach-adams closed 1 year ago

zach-adams commented 1 year ago

Fixes #1446.

Adds a simple "empty" check on the incoming $lead_id to prevent warnings/notices when "null" is passed under certain circumstances (detailed in issue).

Note: After reviewing the rest of the class I think there's a lot of safety/sanity checks & general updates that could/should be made to this Gravity Forms connector class and there's a lack of PHPUnit tests for this connector as well. Since this PR is relatively simple & straightforward I think it's fine to merge for the time being to fix the immediate notices/warnings problem, and I can submit a more detailed improvement issue/PR in the near future to cover a more proper general refactoring. Let me know if that sounds alright or if you'd prefer to wait on this issue/update until that more proper refactoring is ready

Checklist