Closed kasparsd closed 8 months ago
@schlessera I feel like attempting the fallback behaviour might not be in our best interest here because it would actually be different from the previous behaviour. Let's make it a breaking change instead (does this warrant a 4.0.0 release?) and encourage everyone to use the newly introduced filter for adjusting the client IP address on environments where either REMOTE_ADDR
is reporting wrong.
@schlessera I feel like attempting the fallback behaviour might not be in our best interest here because it would actually be different from the previous behaviour. Let's make it a breaking change instead (does this warrant a 4.0.0 release?) and encourage everyone to use the newly introduced filter for adjusting the client IP address on environments where either
REMOTE_ADDR
is reporting wrong.
My 2C.
Fixes #1456.
$_SERVER['REMOTE_ADDR']
as the canonical source for the request origin IP.$_SERVER['REMOTE_ADDR']
is not specified.$_SERVER['HTTP_X_FORWARDED_FOR']
only if$_SERVER['REMOTE_ADDR']
not present.~Checklist
contributing.md
).Release Changelog
$_SERVER['REMOTE_ADDR']
for the source of user IP and fallback to$_SERVER['HTTP_X_FORWARDED_FOR']
only in caseREMOTE_ADDR
is not available. Introduce awp_stream_client_ip_address
filter to adjust the trusted client IP.