xwp / stream

🗄️ Stream plugin for WordPress

https://wordpress.org/plugins/stream/

GNU General Public License v2.0

406 stars 116 forks source link

Fix more PHP 8.1 compatibility issues #1494

Closed delawski closed 1 month ago

delawski commented 1 month ago

Fixes #1493, #1492, #1442.

Describe your approach and how it fixes the issue.

Checklist

[x] Project documentation has been updated to reflect the changes in this pull request, if applicable.
[x] I have tested the changes in the local development environment (see contributing.md).
[x] I have added phpunit tests.

Release Changelog

Fix: Use PHP DateTimeImmutable for handling dates instead of relying on Carbon.
Fix: PHP 8.1 compatibility warnings and errors.

Release Checklist

[ ] This pull request is to the master branch.
[ ] Release version follows semantic versioning. Does it include breaking changes?
[ ] Update changelog in readme.txt.
[ ] Bump version in stream.php.
[ ] Bump Stable tag in readme.txt.
[ ] Bump version in classes/class-plugin.php.
[ ] Draft a release on GitHub.

Change [ ] to [x] to mark the items as done.

delawski commented 1 month ago

@tharsheblows I pushed one more fix to a bug I discovered just today which is the same sort of an issue. It's here: 269ca93

When creating new Alerts, AJAX call is done to WP with a post_id = 'new' (when editing existing alerts, those are real IDs for the alert objects). Since the value was not empty, it passed through the logic up until it attempted to get e.g. ID or post_title out of the nonexistent post.