Open postphotos opened 6 years ago
See Weston's comment on the possible approach: https://xwp.slack.com/archives/C75JEPFDZ/p1522856822000257
Let a user upload a photo of any dimensions. If it is a portrait photo, try to display it in the grid as a portrait slot. If that's not possible, then allow a landscape photo to be cropped to portrait dimensions. The block could try sorting the destinations so that the photos are sorted as (1 portrait|2 landscape)+ But then otherwise fallback to forcing a portrait to be rendered in a landscape slot if otherwise not available.
Hi @miina, I'll turn this into real ACs shortly, but just dropping in from yesterday's meeting.
Featured Destinations
- taxonomy checkbox
- Popular rating
- edit page of a term for location
- upload image in term page
Moving To "QA" Column
The "Featured Destinations" block was part of the merged PR #13. So I'm moving this issue into the "QA" column.
@kienstra This ticket actually has a separate PR as well which is currently still WIP: #34. What #13 included was displaying static block, however as far as I understand, this ticket is for pulling the content dynamically and is still in process.
Thanks for clarifying that, @miina. I moved this back to "In progress."
Request For Testing
Hi Claudio, Could you please test this block?
Expected:
Background image not appearing in IE11:
Question About Images
Hi @csossi, Thanks for testing this. Could you elaborate on "background image not appearing"?
part of the components listed in #12.
As requested (and detailed) by @miina here.
Mockups are available here:
Some notes from #9 apply here: