Closed mehigh closed 6 years ago
Hey, @mehigh, it looks like the markup changes are currently for Gutenberg editor only and not for the actual frontend rendering, was this the intention? There are some new issues with the editor design now:
The Popular block goes "behind" the right bar now, however it's not possible to see the part that's behind the bar. Previously it was possible to scroll left and right on the block to see all the posts, and the posts didn't go behind the sidebar. Same happens with the Activity List block.
Let me know if the changes were actually meant for front-end, then I'll move them over.
@mehigh When you pick this up on Wednesday, do you think you could also check these two small issues on the homepage:
develop
, perhaps it's showing correctly for you locally and it's only my issue since you actually did't make related changes?);develop
, too);Thank you!
The search icon misplacement was caused by a calc() rule containing vars which was getting stripped out by the amp plug-in. I've updated the calc / var rule inside of the sources and recompiled amp-start to get this going.
The icons misalignment with the start and end dates was caused by 3 other calc instances which used vars. Those were getting stripped out, so I computed and placed in the proper em values.
Thanks, Icons Look Good
Hi @mehigh, Thanks for your improvements to the icon alignment. Like you mentioned above, I also see that it's fixed:
The main differences I've noticed when comparing the figma with the ampstart were around two elements:
This PR makes the necessary adjustments to the respective Gutenberg blocks and adds the necessary CSS.
@miina Please check this, and if needed, add the mark-up updates to other locations (if there are any other of course).