xwp / travel

WordPress AMP Adventures Themes (Native AMP)
GNU General Public License v3.0
34 stars 6 forks source link

59: Update header design and layout #67

Closed miina closed 6 years ago

miina commented 6 years ago

Fixes #59.

Todo:

The search page looks like this: screen shot 2018-04-24 at 2 48 18 pm

However, the taxonomy and adventure page look like this and need styling fixes -- for some reason any change made to the adventure.css or archive.css breaks the style, the style fixes are added only to search.css screen shot 2018-04-24 at 2 48 03 pm

miina commented 6 years ago

@kienstra This PR should be ready other than styling issues.

@mehigh Do you think you could review the header, breadcrumbs, and the title's style? The search page needs just a review but adventure and archives page need styling fixes, too -- for some reason here as well as in #64, any change I make to adventure.css or archive.css breaks the style, would be great if you could help with that.

miina commented 6 years ago

Edit: Looks like archive.css looks better after the last change, however, the adventure.css is completely stripped if I make any changes, so this still needs some attention. Currently the header looks like this: screen shot 2018-04-24 at 7 29 26 pm

Basically the difference with other pages is missing this:

.search-travel-btn,
.search-travel-btn:visited{
    margin-left: 25px;
    color: #8b58e3;
}
.travel-date-input{
    line-height:0.125rem
}

Not sure why this breaks the CSS on adventure.css.

(cc @mehigh)

miina commented 6 years ago

@kienstra Thanks for reviewing, the changes are made within 6f5c870.

miina commented 6 years ago

@kienstra and @mehigh Added the missing style change for adventure page as well now, the style just needs reviewing now (and any fixes that Mike might find necessary).

kienstra commented 6 years ago

Approved, Other Than Styling Review

Hi @miina, Your latest changes look good. As you mentioned, this could still a look from Mike. But other than that, it's approved.

kienstra commented 6 years ago

Request For Retro Sanity-Check

@mehigh, if you have time, could you do a quick sanity-check of the styling here? The styling appears well on the archive.php, search.php, and single adventure pages.

But otherwise, I think this is ready to merge.

mehigh commented 6 years ago

CSS looks OK, thanks for the work here @miina !