xwp / travel

WordPress AMP Adventures Themes (Native AMP)
GNU General Public License v3.0
34 stars 6 forks source link

[Gutenberg] Use dynamic images in the carousel at the top of the single "adventure" page #73

Closed postphotos closed 6 years ago

postphotos commented 6 years ago

As an content author working on adventure posts, I want an easy way to manage images that display in the carousel of the single "adventure" page.

(as reported by @kienstra)

kienstra commented 6 years ago

Possible Solution

Hi @miina, What do you think about this approach to making the carousel images dynamic?

kienstra commented 6 years ago

Hi @miina, Feel free to work on this if you'd like. Otherwise, I will 😄

DavidCramer commented 6 years ago

@kienstra @miina I don't mind woking on this 😄 if nobody objects.

miina commented 6 years ago

@DavidCramer No objections from me, go for it!

kienstra commented 6 years ago

Sounds good, @DavidCramer!

kienstra commented 6 years ago

Deployed, UI As Shown In Description

Hi @ThierryA, @DavidCramer's PR for this, #73, is now deployed to the dev site. Though I haven't yet added the additional images for the carousel in the editor.

The UI is as shown in the description.

ThierryA commented 6 years ago

Awesome, thanks @kienstra