search

xwp / travel

WordPress AMP Adventures Themes (Native AMP)
GNU General Public License v3.0
34 stars 6 forks source link

AMP Validation error #77

Closed ThierryA closed 6 years ago

ThierryA commented 6 years ago

There seem to be an error with the search amp list array.

screen shot 2018-05-03 at 11 14 23 am

You can see the error on the home page.

DavidCramer commented 6 years ago

@ThierryA I see the issue. The endpoint is not giving the right structure. Will sort it out.

DavidCramer commented 6 years ago

@postphotos This was a larger problem than just validation. In the ampstart theme ( https://ampstart-iframes.firebaseapp.com/templates/travel/travel.amp ) they tried to implement a predictive search on the search box. However, the template code in the demo is broken so it's not functioning. This broken code was implemented into Travel. I have corrected it now in #79 but it wont function yet since I'll need to implement a refresh to fetch new data. It will be nice to have this function, but we can talk about it in the sprint planning.