xwp / travel

WordPress AMP Adventures Themes (Native AMP)
GNU General Public License v3.0
34 stars 6 forks source link

Fix issue in height of date label #82

Closed kienstra closed 6 years ago

kienstra commented 6 years ago

Request For Code Review

Could you please review this pull request?

Before, these labels didn't have enough line-height:

http://dev-amp-start-travel.pantheonsite.io/adventure/skateboard-around-the-city/

before-labels-line-height

This affected single-adventure.php, archives.php, and search.php: http://dev-amp-start-travel.pantheonsite.io/activity/fashion/ http://dev-amp-start-travel.pantheonsite.io/?s=surfing&start=2018-05-02&end=2018-05-18

With this PR applied:

single-adventure

Though the diff in adventure.css looks extensive, this simply changes line-height: 0.125rem; to line-height: 1.125rem; for .travel-date-input

kienstra commented 6 years ago

Thanks, Applied Changes

Hi @miina, Thanks a lot for reviewing this right away. The commit above applies your suggestion of removing the duplicate rules.

kienstra commented 6 years ago

Thanks, @miina!