Closed kienstra closed 6 years ago
Request For Code Review
Could you please review this pull request?
Before, these labels didn't have enough line-height:
http://dev-amp-start-travel.pantheonsite.io/adventure/skateboard-around-the-city/
This affected single-adventure.php, archives.php, and search.php: http://dev-amp-start-travel.pantheonsite.io/activity/fashion/ http://dev-amp-start-travel.pantheonsite.io/?s=surfing&start=2018-05-02&end=2018-05-18
single-adventure.php
archives.php
search.php
With this PR applied:
Though the diff in adventure.css looks extensive, this simply changes line-height: 0.125rem; to line-height: 1.125rem; for .travel-date-input
adventure.css
line-height: 0.125rem;
line-height: 1.125rem;
.travel-date-input
Thanks, Applied Changes
Hi @miina, Thanks a lot for reviewing this right away. The commit above applies your suggestion of removing the duplicate rules.
Thanks, @miina!
Request For Code Review
Could you please review this pull request?
Before, these labels didn't have enough line-height:
http://dev-amp-start-travel.pantheonsite.io/adventure/skateboard-around-the-city/
This affected
single-adventure.php
,archives.php
, andsearch.php
: http://dev-amp-start-travel.pantheonsite.io/activity/fashion/ http://dev-amp-start-travel.pantheonsite.io/?s=surfing&start=2018-05-02&end=2018-05-18With this PR applied:
Though the diff in
adventure.css
looks extensive, this simply changesline-height: 0.125rem;
toline-height: 1.125rem;
for.travel-date-input