Closed kienstra closed 5 years ago
Request For Code Review
Hi @miina, Would you be available to review this?
For the dynamic blocks, this uses ServerSideRender
.
If you still have this repo set up, please re-run composer install && npm install && npm run dev
Here's the display in the block editor with this PR:
Thanks, Miina! No problem if you're really busy, I could see if someone else is available.
Sure, @kienstra, I'll review it shortly.
Thanks For Reviewing
Hi @miina, Thanks for reviewing this.
https://github.com/xwp/travel/pull/86/commits/4ce2b7fe1257973b51832b298045176606075d77 adds <Disabled>
, though at least in my local in looks like it's still possible to click the links and go to another page, like an 'Activity' link in the 'Activity List' block.
@kienstra Okay, good to know, I had the impression that it would remove pointer events but looks like it might just disable buttons then 🤷♀️
Should be ready for merging then.
Thanks, it might just be my local 😄
Thanks, @miina! Could you please approve this if you're ready?
Thanks!