Prevent persisting Unsplash as default library for user

xwp / unsplash-wp

GNU General Public License v2.0

9 stars 3 forks source link

Prevent persisting Unsplash as default library for user #100

Closed pierlon closed 4 years ago

pierlon commented 4 years ago

Summary

Fixes UVP-189.

Note: When testing, ensure to delete the wp-settings-<user id> cookie, along with the wp_user-settings user metadata for the user.

Checklist

[ ] My pull request is addressing an open issue (please create one otherwise).
[ ] My code is tested and passes existing tests.
[ ] My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

pierlon commented 4 years ago

E2E test failing due to .unsplash-attachment failing accesiblity tests. Can we merge this and fix in a separate PR?

Affected Nodes:

      .unsplash-attachment

        Fix ANY of the following:

        - aria-label attribute does not exist or is empty

        - aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty

        - Element has no title attribute or the title attribute is empty

        - Element does not have text that is visible to screen readers

spacedmonkey commented 4 years ago

Still had tab issues in classic editor with gallery, video and audio.

pierlon commented 4 years ago

Do note that the Unsplash tab can never be set as the last default tab, otherwise the user may see a a screen like this upon plugin deactivation: