Cache api check - Githubissues

xwp / unsplash-wp

GNU General Public License v2.0

9 stars 3 forks source link

Closed spacedmonkey closed 4 years ago

spacedmonkey commented 4 years ago

Run request from send_request to cache results on api check.

Fixes UVP-210

[ ] My pull request is addressing an open issue (please create one otherwise).
[ ] My code is tested and passes existing tests.
[ ] My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

derekherman commented 4 years ago

Why did coverage go down, does this not cover a condition in the new code?

spacedmonkey commented 4 years ago

Why did coverage go down, does this not cover a condition in the new code?

Still a work in progress.

spacedmonkey commented 4 years ago

@ravichdev Can you review. I have tweaked this to reuse existing error message we have in the code base.