xwp / unsplash-wp

GNU General Public License v2.0
9 stars 3 forks source link

A user selects "Search" from the Unsplash block's placeholder and is presented with the Unsplash Media Selector modal #129

Closed bmattb closed 4 years ago

bmattb commented 4 years ago

Feature description

As a user I expect that when I select "Search" from the Unsplash block's placeholder I will be presented with the Unsplash Media Selector modal, in order that I can begin searching for and select an image that I want.

I would expect that the Unsplash Media Selector provides me with a quick and easy way to search and select Unsplash images only, and does not provide me with the abiilty to upload an image from my computer, or use an already exisitng image from my site's Media Library


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

csossi commented 4 years ago

Hi @ravichdev - had this happen when checking error messages as per AC above

Deauthorized the plugin on the Settings page.

When I try to add an Unsplash image via block, I get the error message expected: image

Followed the link to complete setup: image

Returned to post to add image by Unsplash Block, but am still getting an error message: image

bmattb commented 4 years ago

good catch @csossi

ravichdev commented 4 years ago

@csossi I've looked into the Unsplash block "requires setup" error, this is because Pantheon is caching the API request. After the setup is complete, go to Settings > Pantheon Page Cache and click on the "Clear Cache" button, wait for a few seconds and then if you try to insert an image either from the Unsplash or the Image block and the error would disappear