Closed bmattb closed 4 years ago
@ravichdev - Doesn't seem to match figma here (let me know if I'm misunderstanding this one (ccing you @bmattb if you have any comment to add )
Figma has:
While Media Library is showing:
@csossi This ticket is to add the fields and update labels only in the "Media Library" attachment details which can be accessed from wp-admin > Media > Library and select an image imported from Unsplash.
@ravichdev / @spacedmonkey - this ticket was intended to address the presentation of previously imported items in the Media Library regardless of context ie: Unpslash image in media library while viewing the Library assets, and from the Media selector view of previously imported assets. Should this have been broken into two tickets?
After review, I understand that this should have been two tickets. Post insert Media Library is covered here, while Post insert Media Selector is still outstanding. @csossi please only confirm QA on the first scenario - a user viewing an unsplash asset imported into the media library is shown the updated labels & meta (including the link to username on Unpslash)
Verified in QA
Example:
Feature description
As Unsplash we want to change the details presented in the Media Library's Attachment details after a user has so as to provide additional context to the user such as the username of the image provider. Since this addition will require the use of labels for context, the rest of the meta provided has also been updated to include labels.
Currently, the Attachment details for images previously imported appear as"
In order to align with the presentation in the Media Selector, we'd like to change this presentation to include the user name, labels for the fields, as indicated in https://github.com/xwp/unsplash-wp/issues/125
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
wp_prepare_attachment_for_js
filter and add custom properties for Unsplash author, username and created_at to the response.QA testing instructions
Demo
Changelog entry