Fix directory separator issue in Windows

xwp / unsplash-wp

GNU General Public License v2.0

9 stars 3 forks source link

Fix directory separator issue in Windows #201

Closed ravichdev closed 4 years ago

ravichdev commented 4 years ago

Summary

Fixes #194

Checklist

[x] My pull request is addressing an open issue (please create one otherwise).
[ ] My code is tested and passes existing tests.
[x] My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

spacedmonkey commented 4 years ago

Can you explain this change a little @ravichdev . It seems good, but can you explain how this fixes the issue.

ravichdev commented 4 years ago

@spacedmonkey

DIRECTORY_SEPARATOR is \ on windows, Ln:171 replaces the path so the DIRECTORY_SEPARATOR becomes /. But Ln:176 tries to split the path using DIRECTORY_SEPARATOR constant while the path has that value replaced with a /. The fix always splits the path using /.