Fix cropping in WordPress 5.5.

xwp / unsplash-wp

GNU General Public License v2.0

9 stars 3 forks source link

Fix cropping in WordPress 5.5. #202

Closed spacedmonkey closed 4 years ago

spacedmonkey commented 4 years ago

Summary

Fix cropping in WordPress 5.5 - RC1. It was a simple as fixing the return value of the wp_image_file_matches_image_meta filter.

Fixes #173

Checklist

[ ] My pull request is addressing an open issue (please create one otherwise).
[ ] My code is tested and passes existing tests.
[ ] My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

spacedmonkey commented 4 years ago

Looks good, I have one suggestion on the strpos check to ensure it works if the wp_image_file_matches_image_meta method is invoked somewhere without the protocol.

@ravichdev Can you explain this a little more. Not sure what you mean here? I don't check for the proto anywhere, just the domain.