search

xwp / wp-core-media-widgets

Feature plugin for development of new core media widgets for image, video, and audio (and others)
https://wordpress.org/plugins/wp-core-media-widgets/
35 stars 8 forks source link

video looping #130

Open soderlind opened 7 years ago

soderlind commented 7 years ago

Adding a youtube video without doing any changes. Playing it, it loops at the end of the video. If I edit the video and check "loop", it doesn't loop anymore, not even if I uncheck/check and save multiple times.

timmyc commented 7 years ago

totally not related to the bug report, but that cover/video is amazing 😮 !!

timmyc commented 7 years ago

Was able to reproduce with multiple videos - the same experience is not encountered when embeding via the editor either.

timmyc commented 7 years ago

So debugging a bit more, it seems to only be affecting YouTube videos. Embedding a Vimeo video ( I used https://vimeo.com/190372437 ) and upon playing the video it did not loop.

soderlind commented 7 years ago

<offtopic> AURORA has also done a cover of "Half the World Away" by Oasis .. and thanks for pointing me to Frightened Rabbit :) </offtopic>

timmyc commented 7 years ago

Love the 🎵 angle on this issue!

Anyhow, wanted to update the original issue here that the YouTube looping issue appears to be a bug in the underlying mediaelement library version in use in core - details and more discussion on the PR https://github.com/xwp/wp-core-media-widgets/pull/136#issuecomment-299519018

westonruter commented 7 years ago

Re-opening because YouTube is not fixed yet, which apparently depends on https://core.trac.wordpress.org/ticket/39686

rafa8626 commented 7 years ago

Is there a sandbox where I can see this issue and assist you to fix this please? Is this for 4.x version?

westonruter commented 7 years ago

@rafa8626 just install this plugin from GitHub.

rafa8626 commented 7 years ago

Once installed is that all I need to do? Excuse my lack of knowledge in Wordpress

rafa8626 commented 7 years ago

I tried to add a YouTube video through the Add Media button, but when I paste the URL it has all YouTube styles, not MediaElement. Should I be doing this that way? If not, please indicate how so I can assist you and continue to move towards 4.x version. BTW, is this issue on 4.x version, or on 2.x version?

rafa8626 commented 7 years ago

I have submitted a patch on Wordpress ticket. Can you integrate it on your branch and confirm it's fixed, please?