search

xwp / wp-core-media-widgets

Feature plugin for development of new core media widgets for image, video, and audio (and others)
https://wordpress.org/plugins/wp-core-media-widgets/
35 stars 8 forks source link

Make volume tooltip visible #165

Closed timmyc closed 7 years ago

timmyc commented 7 years ago

This branch fixes #140 by adding a z-index value for the mejs volume slider in the context of the customizer and the widget admin. The scrollbar and width of the customizer sidebar still cuts off the toolbar a bit:

customize__wordpress_develop_ _just_another_wordpress_site

Any styling/font changes on the tooltip itself should probably be handled in a core ticket.

Widget Admin:

widgets_ _wordpress_develop_ _wordpress
afercia commented 7 years ago

Opened https://core.trac.wordpress.org/ticket/40707 for core with milestone set to 4.8.

westonruter commented 7 years ago

@afercia does this fix the issue for you?

afercia commented 7 years ago

@westonruter it's fixed in the Widgets screen. As noted by @timmyc it's still cut-off in the customizer because several ancestors use overflow hidden or auto so there's no way to fix it in the customizer sidebar keeping the current tooltip styling and position. Also, still not visible in Chrome because the clip-path not being reset. See in mediaelementplayer.min.css clip-path: polygon(0px 0,0 0,0 0,0 0);

I'd agree these issues should be fixed in core.

timmyc commented 7 years ago

I'm also curious to see if the tooltips have changed in mejs v4 or not.

timmyc commented 7 years ago

so should we merge in this css so the tooltips are at least ( somewhat ) visible here?