xwp / wp-core-media-widgets

Feature plugin for development of new core media widgets for image, video, and audio (and others)
https://wordpress.org/plugins/wp-core-media-widgets/
35 stars 8 forks source link

Media widget placeholder box looks like a dropzone #170

Closed jasmussen closed 7 years ago

jasmussen commented 7 years ago

Let me first exclaim how much I love these new widgets. They look completely great, and work well too.

In the Image, Video and Audio widgets, there's a little dashed line box. This looks like an upload dropzone:

drag drop doesn t work here but it looks like it should

But it's not an upload dropzone.

Two ways to improve this:

Perhaps it's enough to make the dashed line solid, and the background some shade of gray so the box looks like a placeholder. I think it's the dashed lines that makes it feel like it follows a dropzone pattern.

afercia commented 7 years ago

See also https://core.trac.wordpress.org/ticket/34323 and a couple discussions on Slack #design linked in that ticket :)

jasmussen commented 7 years ago

Yaay, it's already on the radar!

melchoyce commented 7 years ago

I'm a +1 for this, but it has to happen in core, so I'm going to close. Can you add your feedback to that trac ticket, @jasmussen?

melchoyce commented 7 years ago

Oh, there's also this ticket I made specifically about turning it into a dropzone: https://core.trac.wordpress.org/ticket/35827

jasmussen commented 7 years ago

I trust your triage completely! Thanks for letting me "ask via ticket", and thanks for the links Mel and Andrea both!

melchoyce commented 7 years ago

The good thing is the media widgets are definitely exposing rough edges in core, that we can hopefully now prioritize :)