search

xwp / wp-customize-posts

Edit posts and postmeta in the WordPress Customizer
https://wordpress.org/plugins/customize-posts/
144 stars 42 forks source link

Clicking on kitchen sink button causes setting to become dirty (and causes a preview refresh) #135

Open pingram3541 opened 8 years ago

pingram3541 commented 8 years ago

Not a biggie but I noticed when toggling the kitchen sink in the editor, it triggers an unnecessary preview refresh on first event. Subsequent toggles do not have this effect.

valendesigns commented 8 years ago

I cannot reproduce this issue. What plugins do you have active?

pingram3541 commented 8 years ago

Just tested on fresh wp 4.5.2 w/ twentysixteen and twentyfifteen themes - no other plugins active. Tested in latest Chrome and Firefox browsers.

http://screencast-o-matic.com/watch/cDhTDcih3y

westonruter commented 8 years ago

@pingram3541 Notice that once you open the kitchen sink, the Customizer saved state changes to dirty. In your JS console, if you could do wp.customize( 'post[post][123]' ).get() before and after you click the kitchen sink, you can then compare what has changed in the post to cause it to become dirty. You can also do JSON.parse( wp.customize.previewer.query().customized ) to see what settings are dirty.