search

xwp / wp-customize-snapshots

Customize Snapshots WordPress Plugin
https://wordpress.org/plugins/customize-snapshots/
52 stars 11 forks source link

Populate back-compat customized state up front for parity with changesets #127

Closed westonruter closed 7 years ago

westonruter commented 7 years ago

I ran into an issue on 4.6 when back-compat snapshots are enabled where attempting to publish a snapshot from the WP Admin would fail and show an “Unrecognized setting” error shown in the WP Admin screen for the snapshots.

This specific plugin had a customize_dynamic_setting_args filter that would short-circuit if the unsanitized_post_values lacked a value for the given $setting_id. This is probably a deficiency with the other plugin as I don't see why it would need to do this, but in any case this ensures the plugin works in 4.6 with back compat snapshots as well as in 4.7 with changesets.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling efd1bdf3f1b3ec8899db6da26ed9cc5f42cf75c7 on bugfix/populate-customized-state-early into on develop.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling efd1bdf3f1b3ec8899db6da26ed9cc5f42cf75c7 on bugfix/populate-customized-state-early into on develop.