search

xwp / wp-customize-snapshots

Customize Snapshots WordPress Plugin
https://wordpress.org/plugins/customize-snapshots/
53 stars 16 forks source link

Remember preview url query params #129

Closed mohdsayed closed 7 years ago

mohdsayed commented 7 years ago

Fixes https://github.com/xwp/wp-customize-snapshots/issues/107

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 75.339% when pulling 6a44a47730444b983469dff305c81beb7bfee88b on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.04%) to 75.24% when pulling 95e139bf1b8b587639c9cc71734f092cea7abc4f on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

mohdsayed commented 7 years ago

Ready for review.

I am not sure if preg_match( '/[a-z|\[|\]|_|-|0-9]+/', $value ) would be the correct choice for validating the panel/section/control id , please suggest

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.06%) to 75.226% when pulling 108c8658e9181c927bbb43ad6cd6c748469090e4 on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 75.395% when pulling 177413727daf0ff627cf1181b3a4deee128e3b2a on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

mohdsayed commented 7 years ago

Class 'PHPUnit_Framework_TestCase' not found in /tmp/wordpress/tests/phpunit/includes/testcase.

Not sure why the build is failing.

westonruter commented 7 years ago

Not sure why the build is failing.

@sayedtaqui it looks like an issue with PHPUnit 6.0. I'm noticing the same thing locally after upgrading from 5.x.

See also https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/870#issuecomment-285260433

See also:

Looks like travis-ci just updated its PHP 7 images to use PHPUnit 6+, so our PHP 7 builds are failing. We should either fast-track #39822 or install + use and older version of PHPUnit in our travis script https://wordpress.slack.com/archives/core/p1489073667330796

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 75.479% when pulling 83dc09f319da11f9da126cfd6c4c8a6d48a3709d on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.8%) to 75.479% when pulling 4caa963c28b3c6178cd905fd403cacba3b4ed64f on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

westonruter commented 7 years ago

@sayedtaqui Ready for merge after you give a final review of my tweaks.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.1%) to 50.176% when pulling f5b55cd172e6166720132a5495f9de712f9d40d9 on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.1%) to 50.176% when pulling 6d9e9a9f80fddb425221fd38917d0f7187219e31 on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.3%) to 76.554% when pulling 43bee5bd5d6d5494288352d076c11d12a96aa9c3 on enhancement/remember-preview-url into 973480f767fb762d7f5a12bed54112b35e628d3e on develop.

mohdsayed commented 7 years ago

👍 Lets merge.