search

xwp / wp-customize-snapshots

Customize Snapshots WordPress Plugin
https://wordpress.org/plugins/customize-snapshots/
53 stars 16 forks source link

Enable status button if current theme is not active. #132

Closed mohdsayed closed 7 years ago

mohdsayed commented 7 years ago

Fixes https://github.com/xwp/wp-customize-snapshots/issues/131

mohdsayed commented 7 years ago

@westonruter We have a param theme=twentyfifteen in url when we switch theme, I think that should also be saved in changeset like we saved the history query params in the other PR?

westonruter commented 7 years ago

@sayedtaqui oh yes, absolutely! That param can be included in the customizer state query params only when saving a changeset for a theme that is not active. If the theme is active, then the param should be omitted from being saved.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 76.537% when pulling 023a0a647b672f95dd143a7b8fbf6083815044d5 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 76.537% when pulling a37228263b257e5d2d784e7898a6b0c2de90665e on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 76.431% when pulling c71add124dc38bd8f15c255642592a01d420cdb7 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 76.431% when pulling 58f0ce9c93061fee329298fd87a7a34f883b38ce on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

westonruter commented 7 years ago

Is this out of WIP and ready for review?

mohdsayed commented 7 years ago

Not ready yet, need to test and may be few changes. Trying to finish today.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 76.388% when pulling cc2f54d4d184d018fcfbe5f83ab7d3529f8271a9 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.2%) to 76.388% when pulling 26f731631ea849f381250e8c3519b203ab6accd4 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

mohdsayed commented 7 years ago

Ready for review.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.3%) to 50.233% when pulling 255945728f3a036eca941dbcc21aca77daeec721 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

westonruter commented 7 years ago

@sayedtaqui the one remaining issue I see, and this isn't strictly related to the changes here, but when I publish the changeset the frontend preview link continues to have the customize_changeset_uuid even though it is published:

image

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.3%) to 50.233% when pulling 9ca3ff2f90df27da5fc62946b7857b61dbcc3184 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.3%) to 50.233% when pulling a71adbb6e63a36061e7a73aabc8f53123ae23340 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.4%) to 50.175% when pulling eb003e337d3a538cefba1bb947e9df2f51eb0cb8 on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-26.4%) to 50.175% when pulling 52694b69390f9544c72e250f3069e77186f5689f on bugfix/issue-131 into c7b91243e5928c2a7b04540ef90e121a084156b3 on develop.