search

xwp / wp-customize-snapshots

Customize Snapshots WordPress Plugin
https://wordpress.org/plugins/customize-snapshots/
52 stars 11 forks source link

Cannot Enter Title on Edit Changeset page for Published Changeset #163

Open jamesdkirk opened 7 years ago

jamesdkirk commented 7 years ago

Just installed Customize Snapshots on brand new WP install (v.4.8.2) Made a few various changes in Customizer, however failed to "Save Draft" on the publish drop down, but did press "Publish" button. Noticed the plugin still lists the edits on the published changeset. What I seem unable to perform is the ability to add a title to the "Enter title here" field. Actually, I can enter a title, however, nothing appears in the "Publish" box to the right. So saving the newly entered title is impossible. On a changeset still in draft mode--even if I've not changed the UUID title during the Customizer session--I am able to make edits to the changeset's title and then re-save in draft mode, or publish that changeset. I can understand not wanting to change a published changeset back to draft status, but is there a specific reason for not being able to add a title to a "(no title)" published changeset?

Thanks in advance for any time helping me to understand this scenario.

westonruter commented 7 years ago

When a changeset is published, it is effectively treated as a “frozen”. It is then essentially a revision that cannot be further edited. That being said, I can see that the ability to change the title after publishing could indeed be useful, such as to provide a description of the changes after publishing.

jamesdkirk commented 7 years ago

Hey Weston That was certainly my experience. I also quickly realized "how things needed to operate" and have adjusted my process accordingly. I think something as simple as some instructions to your points in the plugins info would make that scenario a little clearer. Thanks for the clarification.

westonruter commented 7 years ago

I think it would be useful to add a notification when inspecting a published changeset to explain why it cannot be further edited.

thefrosty commented 6 years ago

Would there be a way to require the title to be filled in as to avoid this change after publication? Either way I would like to see this added (notification or alteration of title for sake of what this changeset was)

westonruter commented 6 years ago

I think it would be better to fix the default changeset title to be something other than the UUID. See #152.