xwp / wp-customize-snapshots

Customize Snapshots WordPress Plugin
https://wordpress.org/plugins/customize-snapshots/
53 stars 16 forks source link

Undefined Index displaying Snapshot Details #172

Closed terriann closed 6 years ago

terriann commented 6 years ago

With Gutenberg enabled, combined with WP Customize Snapshot, when in debug mode, errors are displayed on the snapshot detail page

Notice: Undefined index: title in /Users/Me/Sites/mysite.com/html/wordpress/wp-admin/includes/template.php on line 1042

Reproduction Steps

  1. Login to WordPress Admin with Gutenberg & WP Customize Snapshots enabled and debug mode enabled
  2. Schedule new changes in customizer
  3. View a changeset snapshot
  4. Observe errors displayed on page

Screenshots

screenshot 6

Versions

Plugins and Theme

Theme: Custom child theme of Twentyseventeen (only CSS overrides)

WP Customize Snapshots: 0.7.0 Gutenberg: 1.8.1

Other Version Info

PHP version: 7.8.1 WordPress: 4.9.1

Debugging

I haven't seen this error produced anywhere else in admin while using Gutenberg so I thought this would be the best place to report it but the error does not occur when Gutenberg is disabled. Maybe related https://github.com/WordPress/gutenberg/issues/3813?

westonruter commented 6 years ago

Fixed in https://github.com/WordPress/gutenberg/pull/3856