Closed PatelUtkarsh closed 6 years ago
@PatelUtkarsh Bringing the conversation over to here:
M: When checking the future preview with 1 Snapshot (without conflicts), I could still edit it in Customizer and change a value with clicking "Schedule", is this expected behavior? Maybe it is :)
U: I haven't got approval on that one yet, So if there is only one snapshot we are directly previewing it right now in (#95), Maybe we should fork/duplicate it and preview it. I thought because it is just previewing we can skip extra steps of duplication.
M: When checking the future preview with multiple Snapshots scheduled and when I click Customize and make some edits, it's going to create a new merged Snapshot, is this expected? However, this new Snapshot will not be Scheduled unless scheduled specifically, so it won't actually make any changes. Maybe this can be confusing? Thoughts?
U: Yes, so when you preview from dashboard it creates new merge snapshot with auto-draft status(merging all future snapshots comparing to date). If you start editing it, it will put that in draft status and will allow you to edit.
Okay, thinking that it would be great if previewing a future site would have consistency. So that if I make edits in Customizer while previewing a future site, always X happens. Otherwise it's confusing in terms of UX that in case in code only a single Snapshot is found, then X happens but if more Snapshots are found, Y happens.
Also, it would be good to know somehow that I'm not previewing a Snapshot I've created but the site preview. For example when live previewing a theme, the Customizer has this button instead of the usual Save & Publish
:
Maybe when making edits while previewing, it'd also be useful to use a similar logic and change the button text? Thoughts?
So in a case of a single snapshot we should create a duplicate snapshot to remove that inconsistency (depends on #90), I will add to-do.
About UX I am not sure, @westonruter thoughts?
Should previewing future state where multiple changesets/snapshots are combined have a readonly mode? Should previewing this open on the frontend with the snapshot UUID supplied rather than opening the customizer with the UUID supplied? I should think that the virtual future-merged changesets would be represented in a new auto-draft
snapshot/changeset that would be readonly and wouldn't be used for making edits. If you did want to explicitly edit the merged state, then you could click multiple future snapshots to then merge together into a new snapshot to make that explicit. Some ideas.
Yes, read-only makes sense.
In the case of the read-only preview, I've removed wp_admin_bar link for inspect snapshot
(post-edit) link and customize
(don't add UUID in this case). I've done that in 1e043e9.
@PatelUtkarsh Please fix merge conflicts so I can review. Thanks!
Todo:
Fixes #21
Todos
Dependent on PR #93