search

xwp / wp-dependency-minification

Dependency Minification plugin for WordPress
http://wordpress.org/plugins/dependency-minification/
52 stars 10 forks source link

Flush rewrite rules on activation hook #11

Closed frankiejarrett closed 11 years ago

frankiejarrett commented 11 years ago

When I activated this plugin on BT it broke styles on the site until the permalink rules were flushed. To prevent the extra step, it might be a good idea to invoke flush_rewrite_rules() on the plugin activation hook.

frankiejarrett commented 11 years ago

Well, for that matter, it should be invoked on the deactivation hook as well.

frankiejarrett commented 11 years ago

Welp...I see the activation hook is supposedly already doing this, so I'm not sure why I experienced the issue on BT. Maybe it requires a hard flush?

It's not running on the deactivation hook yet, though.

frankiejarrett commented 11 years ago

Done in https://github.com/x-team/wp-dependency-minification/commit/3b0b589a78d3f502d185a20dc8aaba4e49b75cbf