search

xwp / wp-dependency-minification

Dependency Minification plugin for WordPress
http://wordpress.org/plugins/dependency-minification/
52 stars 10 forks source link

URLs to minified files should respect the protocol #50

Open gnotaras opened 10 years ago

gnotaras commented 10 years ago

When the user visits the web page over SSL, the URLs to minified styles/scripts use the http protocol instead of https.

gnotaras commented 10 years ago

I'm not 100% sure that this is a problem with the plugin. It needs more testing. I'll report back at some later time.

lkraav commented 10 years ago

I'm pretty sure I'm seeing this. I would like the plugin rewrite all minified URL resources with protocol-relative "//" and be done with this issue. Looking into patching it.

lkraav commented 10 years ago

Pull request commit is running on a live server and appears to be behaving nicely. I don't see any drawbacks.

http://www.paulirish.com/2010/the-protocol-relative-url/